AngeloooooandDraculabo
8ed4593f73
* Refactor Gemini model display: filter old versions, group low/high pro, and improve naming * Fix potential negative minutes and refine Gemini 3 Pro grouping logic based on PR feedback * The account change process has been sped up * Address PR review: enhance error message and parameterize polling interval in process handler * Address PR review: fix potential race condition in database backup logic * fix: prevent renderer white screen and harden sentry gating * feat: localize model labels * chore: enable hoisted node-linker * chore: ignore .agent/.claude/.codex in prettier --------- Co-authored-by: Draculabo <[email protected]>
46 lines
1.0 KiB
Markdown
46 lines
1.0 KiB
Markdown
---
|
|
title: Hoist RegExp Creation
|
|
impact: LOW-MEDIUM
|
|
impactDescription: avoids recreation
|
|
tags: javascript, regexp, optimization, memoization
|
|
---
|
|
|
|
## Hoist RegExp Creation
|
|
|
|
Don't create RegExp inside render. Hoist to module scope or memoize with `useMemo()`.
|
|
|
|
**Incorrect (new RegExp every render):**
|
|
|
|
```tsx
|
|
function Highlighter({ text, query }: Props) {
|
|
const regex = new RegExp(`(${query})`, 'gi')
|
|
const parts = text.split(regex)
|
|
return <>{parts.map((part, i) => ...)}</>
|
|
}
|
|
```
|
|
|
|
**Correct (memoize or hoist):**
|
|
|
|
```tsx
|
|
const EMAIL_REGEX = /^[^\s@]+@[^\s@]+\.[^\s@]+$/
|
|
|
|
function Highlighter({ text, query }: Props) {
|
|
const regex = useMemo(
|
|
() => new RegExp(`(${escapeRegex(query)})`, 'gi'),
|
|
[query]
|
|
)
|
|
const parts = text.split(regex)
|
|
return <>{parts.map((part, i) => ...)}</>
|
|
}
|
|
```
|
|
|
|
**Warning (global regex has mutable state):**
|
|
|
|
Global regex (`/g`) has mutable `lastIndex` state:
|
|
|
|
```typescript
|
|
const regex = /foo/g;
|
|
regex.test('foo'); // true, lastIndex = 3
|
|
regex.test('foo'); // false, lastIndex = 0
|
|
```
|