refactor: cut cyclomatic complexity of five hot spots and pin their behavior with tests
Risk labels, menu callback parsing, settings callbacks, table cell width and markdown link targets now use tables and small helpers (CC <= 10).
This commit is contained in:
evandro committed
1 parent
bf4a2021e8
commit
6a6e75fe32
8 files changed
+648
-294
No files matched your search
+115
-107
@@ -492,122 +492,130 @@ export async function updateVoiceReplyModeSettingsMessage(
|
||||
);
|
||||
}
|
||||
|
||||
type TelegramSettingsPageUpdater = (
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
) => Promise<void>;
|
||||
|
||||
const TELEGRAM_SETTINGS_PAGE_UPDATERS = new Map<
|
||||
string,
|
||||
TelegramSettingsPageUpdater
|
||||
>([
|
||||
[
|
||||
"settings:list",
|
||||
(deps) => updateTelegramSettingsMenuMessage(deps, deps.sectionRegistry),
|
||||
],
|
||||
["settings:open:proactive", updateProactivePushSettingsMessage],
|
||||
["settings:open:draft-previews", updateDraftPreviewsSettingsMessage],
|
||||
["settings:open:rich-drafts", updateDraftPreviewsSettingsMessage],
|
||||
["settings:open:assistant-rendering", updateAssistantRenderingSettingsMessage],
|
||||
["settings:open:voice-reply", updateVoiceReplyModeSettingsMessage],
|
||||
["settings:open:time-injection", updateTimeInjectionModeSettingsMessage],
|
||||
["settings:open:time", updateTimeInjectionModeSettingsMessage],
|
||||
]);
|
||||
|
||||
/** Applies one setting value; resolves the toast text, or undefined when the value is invalid */
|
||||
type TelegramSettingsValueApplier = (
|
||||
value: string,
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
) => Promise<string | undefined>;
|
||||
|
||||
async function applyVoiceReplyModeSetting(
|
||||
mode: string,
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
): Promise<string | undefined> {
|
||||
if (
|
||||
mode !== "hidden" &&
|
||||
mode !== "manual" &&
|
||||
mode !== "mirror" &&
|
||||
mode !== "always"
|
||||
) {
|
||||
return undefined;
|
||||
}
|
||||
await deps.setVoiceReplyMode(mode === "hidden" ? undefined : mode);
|
||||
await updateVoiceReplyModeSettingsMessage(deps);
|
||||
return `Voice reply mode: ${mode}`;
|
||||
}
|
||||
|
||||
async function applyTimeInjectionModeSetting(
|
||||
mode: string,
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
): Promise<string | undefined> {
|
||||
const normalizedMode = mode === "off" ? "hidden" : mode;
|
||||
if (
|
||||
normalizedMode !== "hidden" &&
|
||||
normalizedMode !== "always" &&
|
||||
normalizedMode !== "interval"
|
||||
) {
|
||||
return undefined;
|
||||
}
|
||||
await deps.setTimeInjectionMode(normalizedMode);
|
||||
await updateTimeInjectionModeSettingsMessage(deps);
|
||||
return `Time injection: ${normalizedMode}`;
|
||||
}
|
||||
|
||||
async function applyDraftPreviewsSetting(
|
||||
value: string,
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
): Promise<string | undefined> {
|
||||
if (value !== "on" && value !== "off") return undefined;
|
||||
const enabled = value === "on";
|
||||
await deps.setDraftPreviewsEnabled(enabled);
|
||||
await updateDraftPreviewsSettingsMessage(deps);
|
||||
return `Draft previews ${enabled ? "enabled" : "disabled"}`;
|
||||
}
|
||||
|
||||
async function applyAssistantRenderingSetting(
|
||||
mode: string,
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
): Promise<string | undefined> {
|
||||
if (mode !== "rich" && mode !== "html") return undefined;
|
||||
await deps.setAssistantRenderingMode(mode);
|
||||
await updateAssistantRenderingSettingsMessage(deps);
|
||||
return `Rendering: ${mode}`;
|
||||
}
|
||||
|
||||
async function applyProactivePushSetting(
|
||||
value: string,
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
): Promise<string | undefined> {
|
||||
if (value !== "on" && value !== "off") return undefined;
|
||||
const enabled = value === "on";
|
||||
await deps.setProactivePushEnabled(enabled);
|
||||
await updateProactivePushSettingsMessage(deps);
|
||||
return `Proactive push ${enabled ? "enabled" : "disabled"}`;
|
||||
}
|
||||
|
||||
const TELEGRAM_SETTINGS_VALUE_APPLIERS: Array<
|
||||
[prefix: string, apply: TelegramSettingsValueApplier]
|
||||
> = [
|
||||
["settings:set:voice-reply:", applyVoiceReplyModeSetting],
|
||||
["settings:set:time-injection:", applyTimeInjectionModeSetting],
|
||||
["settings:set:time:", applyTimeInjectionModeSetting],
|
||||
["settings:set:draft-previews:", applyDraftPreviewsSetting],
|
||||
["settings:set:rich-drafts:", applyDraftPreviewsSetting],
|
||||
["settings:set:assistant-rendering:", applyAssistantRenderingSetting],
|
||||
["settings:set:proactive:", applyProactivePushSetting],
|
||||
];
|
||||
|
||||
export async function handleTelegramSettingsMenuCallbackAction(
|
||||
callbackQueryId: string,
|
||||
data: string | undefined,
|
||||
deps: TelegramSettingsMenuCallbackDeps,
|
||||
): Promise<boolean> {
|
||||
if (!data?.startsWith("settings:")) return false;
|
||||
if (data === "settings:list") {
|
||||
await updateTelegramSettingsMenuMessage(deps, deps.sectionRegistry);
|
||||
const updatePage = TELEGRAM_SETTINGS_PAGE_UPDATERS.get(data);
|
||||
if (updatePage) {
|
||||
await updatePage(deps);
|
||||
await deps.answerCallbackQuery(callbackQueryId);
|
||||
return true;
|
||||
}
|
||||
if (data === "settings:open:proactive") {
|
||||
await updateProactivePushSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(callbackQueryId);
|
||||
return true;
|
||||
}
|
||||
if (data === "settings:open:draft-previews" || data === "settings:open:rich-drafts") {
|
||||
await updateDraftPreviewsSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(callbackQueryId);
|
||||
return true;
|
||||
}
|
||||
if (data === "settings:open:assistant-rendering") {
|
||||
await updateAssistantRenderingSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(callbackQueryId);
|
||||
return true;
|
||||
}
|
||||
if (data === "settings:open:voice-reply") {
|
||||
await updateVoiceReplyModeSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(callbackQueryId);
|
||||
return true;
|
||||
}
|
||||
if (
|
||||
data === "settings:open:time-injection" ||
|
||||
data === "settings:open:time"
|
||||
) {
|
||||
await updateTimeInjectionModeSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(callbackQueryId);
|
||||
return true;
|
||||
}
|
||||
if (data.startsWith("settings:set:voice-reply:")) {
|
||||
const mode = data.slice("settings:set:voice-reply:".length);
|
||||
if (
|
||||
mode === "hidden" ||
|
||||
mode === "manual" ||
|
||||
mode === "mirror" ||
|
||||
mode === "always"
|
||||
) {
|
||||
await deps.setVoiceReplyMode(mode === "hidden" ? undefined : mode);
|
||||
await updateVoiceReplyModeSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(
|
||||
callbackQueryId,
|
||||
`Voice reply mode: ${mode}`,
|
||||
);
|
||||
return true;
|
||||
}
|
||||
}
|
||||
if (
|
||||
data.startsWith("settings:set:time-injection:") ||
|
||||
data.startsWith("settings:set:time:")
|
||||
) {
|
||||
const mode = data.startsWith("settings:set:time-injection:")
|
||||
? data.slice("settings:set:time-injection:".length)
|
||||
: data.slice("settings:set:time:".length);
|
||||
const normalizedMode = mode === "off" ? "hidden" : mode;
|
||||
if (
|
||||
normalizedMode === "hidden" ||
|
||||
normalizedMode === "always" ||
|
||||
normalizedMode === "interval"
|
||||
) {
|
||||
await deps.setTimeInjectionMode(normalizedMode);
|
||||
await updateTimeInjectionModeSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(
|
||||
callbackQueryId,
|
||||
`Time injection: ${normalizedMode}`,
|
||||
);
|
||||
return true;
|
||||
}
|
||||
}
|
||||
if (
|
||||
data === "settings:set:draft-previews:on" ||
|
||||
data === "settings:set:draft-previews:off" ||
|
||||
data === "settings:set:rich-drafts:on" ||
|
||||
data === "settings:set:rich-drafts:off"
|
||||
) {
|
||||
const enabled = data.endsWith(":on");
|
||||
await deps.setDraftPreviewsEnabled(enabled);
|
||||
await updateDraftPreviewsSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(
|
||||
callbackQueryId,
|
||||
`Draft previews ${enabled ? "enabled" : "disabled"}`,
|
||||
);
|
||||
return true;
|
||||
}
|
||||
if (data.startsWith("settings:set:assistant-rendering:")) {
|
||||
const mode = data.slice("settings:set:assistant-rendering:".length);
|
||||
if (mode === "rich" || mode === "html") {
|
||||
await deps.setAssistantRenderingMode(mode);
|
||||
await updateAssistantRenderingSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(callbackQueryId, `Rendering: ${mode}`);
|
||||
return true;
|
||||
}
|
||||
}
|
||||
if (
|
||||
data === "settings:set:proactive:on" ||
|
||||
data === "settings:set:proactive:off"
|
||||
) {
|
||||
const enabled = data.endsWith(":on");
|
||||
await deps.setProactivePushEnabled(enabled);
|
||||
await updateProactivePushSettingsMessage(deps);
|
||||
await deps.answerCallbackQuery(
|
||||
callbackQueryId,
|
||||
`Proactive push ${enabled ? "enabled" : "disabled"}`,
|
||||
);
|
||||
return true;
|
||||
}
|
||||
await deps.answerCallbackQuery(callbackQueryId);
|
||||
const applier = TELEGRAM_SETTINGS_VALUE_APPLIERS.find(([prefix]) =>
|
||||
data.startsWith(prefix),
|
||||
);
|
||||
const toast = applier
|
||||
? await applier[1](data.slice(applier[0].length), deps)
|
||||
: undefined;
|
||||
await deps.answerCallbackQuery(callbackQueryId, toast);
|
||||
return true;
|
||||
}
|
||||
|
||||
|
||||
Reference in new issue
Block a user